Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a case for build_class to handle class names with underscores passed as a string #1642

Conversation

m-gizzi
Copy link
Contributor

@m-gizzi m-gizzi commented May 8, 2024

Fixes #1588

Fixes a bug where a class defined with underscores, ex. factory :customs_declaration_nl_ddu_1, class: "Customs::Declarations::NL::DDU_1_0" strips out the underscores and then raises an NameError.

…assed as a string

Co-authored-by: Michelle Yuen <[email protected]>
Co-authored-by: Stephanie Minn <[email protected]>
@m-gizzi m-gizzi requested a review from mike-burns as a code owner May 8, 2024 15:35
@stephanieminn stephanieminn merged commit c791452 into thoughtbot:main May 20, 2024
19 checks passed
@stephanieminn
Copy link
Contributor

stephanieminn commented May 20, 2024

@m-gizzi @yuenmichelle1 I went ahead and merged this! thanks for working on it together 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underscores being removed from class name during tests
3 participants