kmod: fix hda-sdw-bpt dependency #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to remove the SoundWire parts before removing hda-sdw-bpt rmmod: ERROR: Module snd_sof_intel_hda_common is in use by: snd_sof_intel_hda_sdw_bpt Link: https://sof-ci.01.org/linuxpr/PR4679/build1181/devicetest/index.html?model=MTLP_SDW_AIOC&testcase=check-kmod-load-unload Signed-off-by: Pierre-Louis Bossart <[email protected]>
marc-hb
approved these changes
Jan 25, 2024
compatible with sof-dev for sure, and with my update in thesofproject/linux#4679. |
It's not compatible with 6.5: |
|
workaround: --- a/tools/kmod/sof_remove.sh
+++ b/tools/kmod/sof_remove.sh
@@ -117,12 +117,13 @@ remove_module snd_soc_avs
remove_module snd_soc_hda_codec
#-------------------------------------------
# platform drivers
#-------------------------------------------
remove_module snd_sof_intel_hda_generic
+remove_module snd_sof_intel_hda_common
#-------------------------------------------
# SoundWire/SOF parts
#-------------------------------------------
remove_module soundwire_intel_init
remove_module soundwire_intel |
marc-hb
added a commit
to marc-hb/sof-test
that referenced
this pull request
Apr 25, 2024
Fixes this failure with older kernel like the 6.5 kernels distributed by Ubuntu: ERROR: Module soundwire_intel is in use by: snd_sof_intel_hda_common Fixes commit 65951c4 ("kmod: fix hda-sdw-bpt dependency") which unloaded all soundwire drivers earlier as a block. This is not a problem with 6.9-ish kernels where snd_sof_intel_hda_common and soundwire_intel can apparently be unloaded in any order but it is a problem with older kernels. So, unload `snd_sof_intel_hda_common` before soundwire modules to be compatible with any kernel. See thesofproject#1156 for more info.
Fix submitted: |
marc-hb
added a commit
to marc-hb/sof-test
that referenced
this pull request
Apr 30, 2024
Fixes this failure with older kernel like the 6.5 kernels distributed by Ubuntu: ERROR: Module soundwire_intel is in use by: snd_sof_intel_hda_common Fixes commit 65951c4 ("kmod: fix hda-sdw-bpt dependency") which unloaded all soundwire drivers earlier as a block. This is not a problem with 6.9-ish kernels where snd_sof_intel_hda_common and soundwire_intel can apparently be unloaded in any order but it is a problem with older kernels. So, unload `snd_sof_intel_hda_common` before soundwire modules to be compatible with any kernel. See thesofproject#1156 for more info.
marc-hb
added a commit
that referenced
this pull request
May 1, 2024
Fixes this failure with older kernel like the 6.5 kernels distributed by Ubuntu: ERROR: Module soundwire_intel is in use by: snd_sof_intel_hda_common Fixes commit 65951c4 ("kmod: fix hda-sdw-bpt dependency") which unloaded all soundwire drivers earlier as a block. This is not a problem with 6.9-ish kernels where snd_sof_intel_hda_common and soundwire_intel can apparently be unloaded in any order but it is a problem with older kernels. So, unload `snd_sof_intel_hda_common` before soundwire modules to be compatible with any kernel. See #1156 for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove the SoundWire parts before removing hda-sdw-bpt
rmmod: ERROR: Module snd_sof_intel_hda_common is in use by: snd_sof_intel_hda_sdw_bpt
Link: https://sof-ci.01.org/linuxpr/PR4679/build1181/devicetest/index.html?model=MTLP_SDW_AIOC&testcase=check-kmod-load-unload