Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build via CMake #88

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

ataulien
Copy link

@ataulien ataulien commented Oct 21, 2018

See issue #87.

This is WIP - Don't merge yet!

@strega-nil strega-nil mentioned this pull request Oct 21, 2018
@ataulien ataulien changed the title WIP: Build via CMake [WIP] Build via CMake Oct 22, 2018
@dongcarl
Copy link

dongcarl commented Dec 3, 2018

@ataulien What is the progress with this? It seems like the checks are passing? Anything more to do?

@ataulien
Copy link
Author

ataulien commented Dec 3, 2018

CMake isn't used by the CI system yet. The compiler itself builds fine, the standard libraries can be built as well, but there are some features in the original makefiles which I haven't ported over.

Edit: heh, it seems like I didn't push the latest changes. Let me do that quickly...

@dongcarl
Copy link

dongcarl commented Dec 3, 2018

@ataulien I think as long as mrustc and minicargo builds fine with cmake, there could be a separate PR for the rest?

Just wondering what's missing and how I could help.

@dongcarl
Copy link

dongcarl commented Dec 8, 2018

@ataulien Travis isn't happy

@ataulien
Copy link
Author

ataulien commented Dec 9, 2018

@dongcarl It seems to just hand at some point while ninja runs. I'll have a look at it tomorrow or so.

@ataulien
Copy link
Author

"Tomorrow" is today and I got the build working on travis. Turns out using make instead of ninja and getting rid of set -e makes it work.

It builds mrustc and minicargo just fine, but still fails at compiling the rust std-libraries.

@thepowersgang
Copy link
Owner

thepowersgang commented Dec 22, 2018

If you make rust_libpanic_unwind and rust_libtest depend on rust_libstd then the standard library should compile.

Also, libproc_macro is a custom crate, its source is in lib/libproc_macro

@dongcarl
Copy link

@ataulien Any more progress on this? What's missing now?

@rdrpenguin04
Copy link

The referenced issue has been closed; is this needed anymore?

@thepowersgang
Copy link
Owner

Probably not needed? I feel that cmake is a little too much complexity to manage over just having a vsproject and makefile.

@orowith2os
Copy link
Contributor

I think I'll note that I would love to see meson - makes it easier to integrate in some build system stuff I tend to tinker with (Flatpak, freedesktop-sdk)

@thepowersgang
Copy link
Owner

I think I'll note that I would love to see meson - makes it easier to integrate in some build system stuff I tend to tinker with (Flatpak, freedesktop-sdk)

If mrustc gets a unified build system, it'd most likely be cmake - because cmake is already needed for llvm, and because I use it for my day job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants