Fix -Wmaybe-uninitialized warnings in move constructors #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With GCC 9, x.m_ptr was triggering -Wmaybe-uninitialized. This seems to silence the warnings without changing the behavior.
|
Seems strange that this would be triggering a warning, seems like pretty simple logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With GCC 9, x.m_ptr was triggering -Wmaybe-uninitialized.
This seems to silence the warnings without changing the behavior.
(This is purely cosmetic, so feel free to close if you prefer the existing style. This warning can pop up in other spurious contexts so you may prefer to silence it entirely.)