Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #100 update deprecated constants in doctrine #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JasonMartoux
Copy link

@JasonMartoux JasonMartoux commented May 19, 2024

fix #100 deprecated constant Lexer for TokenType constant in doctrine/orm 2.19 see here

@JasonMartoux JasonMartoux changed the title (fix) deprecated constants in doctrine fix #100 update deprecated constants in doctrine May 19, 2024
@MaximeThoonsen
Copy link
Collaborator

Hey @JasonMartoux,
I think we need to add support for multiple Doctrine version to make this works

@JasonMartoux
Copy link
Author

@MaximeThoonsen Hey !
The deprecation started at the version 2.19 of doctrine/orm.
I've forked the repo yesterday (Omega good job by the way 👍 mate ), and got the issue. Maybe update the doc in the meantime ?

@MaximeThoonsen
Copy link
Collaborator

Hey @JasonMartoux ,
Thanks for the kind words!
Yes you are right, I will update the doc. Do you want to suggest a fix that works for many doctrine version?

@JasonMartoux
Copy link
Author

@MaximeThoonsen just fix the version in the composer file ?

@MaximeThoonsen
Copy link
Collaborator

@JasonMartoux no because we want to let as many people as possible use it and they all have different version. We don't want to create a version conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Undefined constant Doctrine\ORM\Query\Lexer::T_IDENTIFIER
2 participants