-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extra function to return function return value from chat #120
Closed
Closed
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a69d543
Added function return value to chat array
samuelgjekic 4964810
Added function to OllamaChat but OllamaChat
samuelgjekic 8e5cb06
Linter fix
samuelgjekic 51459a3
Store the last response object from OpenAI (#116)
ezimuel c561cf5
Allow custom client for MistralEmbeddingGenerator
thomasbeaujean 09e3f9d
update readme
MaximeThoonsen b31ae4b
Added retrieved documents in QuestionAnswering
ezimuel e795789
Fixed empty array for refactor test
ezimuel 2bea67e
Fixed the generateTextOrReturnFunction method
samuelgjekic cc01090
Added GPT4Omni
samuelgjekic e2942cb
Merge branch 'main' of https://github.com/samuelgjekic/LLPhant
samuelgjekic f0b6d2f
Lint error Fix
samuelgjekic e5780db
Added function return value to chat array
samuelgjekic ef2d00e
Added function to OllamaChat but OllamaChat
samuelgjekic 6a3dbef
Linter fix
samuelgjekic f0d3e02
Fixed the generateTextOrReturnFunction method
samuelgjekic 409e537
Lint error Fix
samuelgjekic 63da418
Rebase of commit
samuelgjekic File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @samuelgjekic,
I think it is great to add this possibility.
what if the previous answer was a function and now it is a text but the lastFunctionCalled is still the FunctionInfo from the previous call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm i did not think about this, my bad.. Anyways, does this not apply to the generateTextOrReturnFunction aswell? As they are the same.
I added a line that sets the lastFunction to null in the start of the method, is this good, or do you prefer that i check if $toolstocall is not null instead? If so dont merge yet and i will do it that way instead.