Fixes #37478 - Add host power status column to new All Hosts page #10171
Conversation
| @@ -10,6 +10,7 @@ class PowerStatus < Base | |||
|
|
|||
| def power_state(timeout = DEFAULT_TIMEOUT) | |||
| result = { id: host.id }.merge(HOST_POWER[:na]) | |||
| return random_power_state | |||
There was a problem hiding this comment.
I added this commit to make testing easier. Will remove it once acked. You can comment out this line to switch back to returning the real power status.
| const green = '#6ec664'; | ||
| const disabledGray = '#d2d2d2'; | ||
| switch (state) { | ||
| case 'on': | ||
| powerIcon = ( | ||
| <span style={{ ...moveItALittleUp, color: green }}> | ||
| <PowerOnIcon title={tooltipText} /> | ||
| </span> | ||
| ); | ||
| break; | ||
| case 'off': | ||
| powerIcon = ( | ||
| <span style={{ ...moveItALittleUp }}> | ||
| <PowerOffIcon title={tooltipText} /> | ||
| </span> | ||
| ); | ||
| break; | ||
| default: | ||
| powerIcon = ( | ||
| <span style={{ ...moveItALittleUp, color: disabledGray }}> | ||
| <UnknownIcon title={tooltipText} /> | ||
| </span> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Please use icon status instead of hardcoding colors https://v4-archive.patternfly.org/v4/components/icon#status-colors
There was a problem hiding this comment.
The old page has colored power icons. The PF4 status icons aren't power icons so it would be confusing to use, for example, a "success" icon to mean power on.
There was a problem hiding this comment.
Can you use pf css variables to do that? I mostly dont want just string colors hashes in the code
There was a problem hiding this comment.
@MariaAga Updated to use PF css variables. 👍
This adds a Power Status column to the new All Hosts page.
Since there is no bulk endpoint for power status, I decided to use the existing API endpoint
/hosts/power.per_pageAPI requests at a time. This seems reasonable to me.I added a fake delay and random power status for ease of testing. This will wait 1-4 seconds and give you a random power status back. This way you can see what it looks like when requests come in at different times.
The old page had red for powered off, but I decided to go with black here; it seems a bit less harsh.
I used the PF4-recommended icons for denoting "powered on," "powered off," and "unknown state."