Add tests for clicks #5
Conversation
|
why cant i just use container methods 😭 |
| @@ -18,6 +18,7 @@ function ConeOrCube(props: { piece: cubeOrCone }): JSX.Element { | |||
| return ( | |||
| <div | |||
| className="coneOrCube" | |||
| role="none" | |||
There was a problem hiding this comment.
Isn't none the default role for a <div>?
There was a problem hiding this comment.
ESLint complained about it - but maybe i had something there before
There was a problem hiding this comment.
the tests dont passif the role isnt defined as none
There was a problem hiding this comment.
Well, we shouldn't be setting the ARIA role to none anyway. It sounds like your tests are abusing the ARIA role to select this element. Maybe find a different selector? You have a class name on this after all...
| @@ -18,6 +18,7 @@ function ConeOrCube(props: { piece: cubeOrCone }): JSX.Element { | |||
| return ( | |||
| <div | |||
| className="coneOrCube" | |||
| role="none" | |||
There was a problem hiding this comment.
Well, we shouldn't be setting the ARIA role to none anyway. It sounds like your tests are abusing the ARIA role to select this element. Maybe find a different selector? You have a class name on this after all...
Add tests for interactive components using the react testing library