Skip to content

Commit

Permalink
chore: fix typos (microsoft#30645)
Browse files Browse the repository at this point in the history
  • Loading branch information
szepeviktor authored and thebigbrain committed May 12, 2024
1 parent d00116f commit e95c462
Show file tree
Hide file tree
Showing 41 changed files with 61 additions and 61 deletions.
4 changes: 2 additions & 2 deletions docs/src/api/class-locatorassertions.md
Original file line number Diff line number Diff line change
Expand Up @@ -910,10 +910,10 @@ await expect(
assertThat(page.getByText("Welcome")).isVisible();

// At least one item in the list is visible.
asserThat(page.getByTestId("todo-item").first()).isVisible();
assertThat(page.getByTestId("todo-item").first()).isVisible();

// At least one of the two elements is visible, possibly both.
asserThat(
assertThat(
page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Sign in"))
.or(page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Sign up")))
.first()
Expand Down
4 changes: 2 additions & 2 deletions docs/src/api/params.md
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ Whether to emulate network being offline. Defaults to `false`. Learn more about
- `username` <[string]>
- `password` <[string]>
- `origin` ?<[string]> Restrain sending http credentials on specific origin (scheme://host:port).
- `sendImmediately` ?<[boolean]> Whether to send `Authorization` header with the first API request. By deafult, the credentials are sent only when 401 (Unauthorized) response with `WWW-Authenticate` header is received. This option does not affect requests sent from the browser.
- `sendImmediately` ?<[boolean]> Whether to send `Authorization` header with the first API request. By default, the credentials are sent only when 401 (Unauthorized) response with `WWW-Authenticate` header is received. This option does not affect requests sent from the browser.

Credentials for [HTTP authentication](https://developer.mozilla.org/en-US/docs/Web/HTTP/Authentication).
If no origin is specified, the username and password are sent to any servers upon unauthorized responses.
Expand Down Expand Up @@ -751,7 +751,7 @@ Whether to allow sites to register Service workers. Defaults to `'allow'`.
* since: v1.41
- `behavior` <[UnrouteBehavior]<"wait"|"ignoreErrors"|"default">>

Specifies wether to wait for already running handlers and what to do if they throw errors:
Specifies whether to wait for already running handlers and what to do if they throw errors:
* `'default'` - do not wait for current handler calls (if any) to finish, if unrouted handler throws, it may result in unhandled error
* `'wait'` - wait for current handler calls (if any) to finish
* `'ignoreErrors'` - do not wait for current handler calls (if any) to finish, all errors thrown by the handlers after unrouting are silently caught
Expand Down
2 changes: 1 addition & 1 deletion docs/src/codegen.md
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ pwsh bin/Debug/netX/playwright.ps1 codegen github.com/microsoft/playwright --sav

After performing authentication and closing the browser, `auth.json` will contain the storage state which you can then reuse in your tests.

<img width="1394" alt="login to Github screen" src="https://user-images.githubusercontent.com/13063165/220561688-04b2b984-4ba6-4446-8b0a-8058876e2a02.png" />
<img width="1394" alt="login to GitHub screen" src="https://user-images.githubusercontent.com/13063165/220561688-04b2b984-4ba6-4446-8b0a-8058876e2a02.png" />

Make sure you only use the `auth.json` locally as it contains sensitive information. Add it to your `.gitignore` or delete it once you have finished generating your tests.

Expand Down
2 changes: 1 addition & 1 deletion docs/src/test-api/class-test.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ test('my test', async ({ page }) => {
});
```

Alternatively, you can delcare a hook **with a title**.
Alternatively, you can declare a hook **with a title**.

```js title="example.spec.ts"
test.afterEach('Status check', async ({ page }) => {
Expand Down
4 changes: 2 additions & 2 deletions docs/src/test-cli-js.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ Complete set of Playwright Test options is available in the [configuration file]
| `--debug`| Run tests with Playwright Inspector. Shortcut for `PWDEBUG=1` environment variable and `--timeout=0 --max-failures=1 --headed --workers=1` options.|
| `--forbid-only` | Whether to disallow `test.only`. Useful on CI.|
| `--global-timeout <number>` | Total timeout for the whole test run in milliseconds. By default, there is no global timeout. Learn more about [various timeouts](./test-timeouts.md).|
| `-g <grep>` or `--grep <grep>` | Only run tests matching this regular expression. For example, this will run `'should add to cart'` when passed `-g "add to cart"`. The regular expression will be tested against the string that consists of the test file name, `test.describe` titles if any, test title and all test tags, separated by spaces, e.g. `my-test.spec.ts my-suite my-test @smoke`. The filter does not apply to the tests from dependcy projects, i.e. Playwright will still run all tests from [project dependencies](./test-projects.md#dependencies). |
| `--grep-invert <grep>` | Only run tests **not** matching this regular expression. The opposite of `--grep`. The filter does not apply to the tests from dependcy projects, i.e. Playwright will still run all tests from [project dependencies](./test-projects.md#dependencies).|
| `-g <grep>` or `--grep <grep>` | Only run tests matching this regular expression. For example, this will run `'should add to cart'` when passed `-g "add to cart"`. The regular expression will be tested against the string that consists of the test file name, `test.describe` titles if any, test title and all test tags, separated by spaces, e.g. `my-test.spec.ts my-suite my-test @smoke`. The filter does not apply to the tests from dependency projects, i.e. Playwright will still run all tests from [project dependencies](./test-projects.md#dependencies). |
| `--grep-invert <grep>` | Only run tests **not** matching this regular expression. The opposite of `--grep`. The filter does not apply to the tests from dependency projects, i.e. Playwright will still run all tests from [project dependencies](./test-projects.md#dependencies).|
| `--headed` | Run tests in headed browsers. Useful for debugging. |
| `--ignore-snapshots` | Whether to ignore [snapshots](./test-snapshots.md). Use this when snapshot expectations are known to be different, e.g. running tests on Linux against Windows screenshots. |
| `--last-failed` | Only re-run the failures.|
Expand Down
2 changes: 1 addition & 1 deletion docs/src/test-parallel-js.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export const test = baseTest.extend<{}, { dbUserName: string }>({
dbUserName: [async ({ }, use) => {
// Use workerIndex as a unique identifier for each worker.
const userName = `user-${test.info().workerIndex}`;
// Inialize user in the database.
// Initialize user in the database.
await createUserInTestDatabase(userName);
await use(userName);
// Clean up after the tests are done.
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-core/src/server/chromium/crPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@ class FrameSession {
return;
}
if (reason === 'swap') {
// This is a local -> remote frame transtion, where
// This is a local -> remote frame transition, where
// Page.frameDetached arrives before Target.attachedToTarget.
// We should keep the frame in the tree, and it will be used for the new target.
const frame = this._page._frameManager.frame(frameId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ export class DispatcherConnection {
}
}
response.error = serializeError(e);
// The command handler could have set error in the metada, do not reset it if there was no exception.
// The command handler could have set error in the metadata, do not reset it if there was no exception.
callMetadata.error = response.error;
} finally {
callMetadata.endTime = monotonicTime();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class JSHandleDispatcher extends Dispatcher<js.JSHandle, channels.JSHandl
}

// Generic channel parser converts guids to JSHandleDispatchers,
// and this function takes care of coverting them into underlying JSHandles.
// and this function takes care of converting them into underlying JSHandles.
export function parseArgument(arg: channels.SerializedArgument): any {
return parseSerializedValue(arg.value, arg.handles.map(a => (a as JSHandleDispatcher)._object));
}
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-core/src/server/frames.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export type NavigationEvent = {
// Error for cross-document navigations if any. When error is present,
// the navigation did not commit.
error?: Error,
// Wether this event should be visible to the clients via the public APIs.
// Whether this event should be visible to the clients via the public APIs.
isPublic?: boolean;
};

Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-core/src/server/har/harTracer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ export class HarTracer {
});
this._addBarrier(page || request.serviceWorker(), promise);

// Respose end timing is only available after the response event was received.
// Response end timing is only available after the response event was received.
const timing = response.timing();
harEntry.timings.receive = response.request()._responseEndTiming !== -1 ? helper.millisToRoundishMillis(response.request()._responseEndTiming - timing.responseStart) : -1;
this._computeHarEntryTotalTime(harEntry);
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-core/src/server/injected/roleUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ function getTextAlternativeInternal(element: Element, options: AccessibleNameOpt
if (trimFlatString(title))
return title;
// SPEC DIFFERENCE.
// Spec says return localized "Submit Query", but browsers and axe-core insist on "Sumbit".
// Spec says return localized "Submit Query", but browsers and axe-core insist on "Submit".
return 'Submit';
}

Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-core/src/server/input.ts
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ function buildLayoutClosure(layout: keyboardLayout.KeyboardLayout): Map<string,
shiftedDescription.keyCode = definition.shiftKeyCode;
}

// Map from code: Digit3 -> { ... descrption, shifted }
// Map from code: Digit3 -> { ... description, shifted }
result.set(code, { ...description, shifted: shiftedDescription });

// Map from aliases: Shift -> non-shiftable definition
Expand Down
16 changes: 8 additions & 8 deletions packages/playwright-core/types/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4390,7 +4390,7 @@ export interface Page {
*/
unrouteAll(options?: {
/**
* Specifies wether to wait for already running handlers and what to do if they throw errors:
* Specifies whether to wait for already running handlers and what to do if they throw errors:
* - `'default'` - do not wait for current handler calls (if any) to finish, if unrouted handler throws, it may
* result in unhandled error
* - `'wait'` - wait for current handler calls (if any) to finish
Expand Down Expand Up @@ -8827,7 +8827,7 @@ export interface BrowserContext {
*/
unrouteAll(options?: {
/**
* Specifies wether to wait for already running handlers and what to do if they throw errors:
* Specifies whether to wait for already running handlers and what to do if they throw errors:
* - `'default'` - do not wait for current handler calls (if any) to finish, if unrouted handler throws, it may
* result in unhandled error
* - `'wait'` - wait for current handler calls (if any) to finish
Expand Down Expand Up @@ -13378,7 +13378,7 @@ export interface BrowserType<Unused = {}> {
origin?: string;

/**
* Whether to send `Authorization` header with the first API request. By deafult, the credentials are sent only when
* Whether to send `Authorization` header with the first API request. By default, the credentials are sent only when
* 401 (Unauthorized) response with `WWW-Authenticate` header is received. This option does not affect requests sent
* from the browser.
*/
Expand Down Expand Up @@ -14901,7 +14901,7 @@ export interface AndroidDevice {
origin?: string;

/**
* Whether to send `Authorization` header with the first API request. By deafult, the credentials are sent only when
* Whether to send `Authorization` header with the first API request. By default, the credentials are sent only when
* 401 (Unauthorized) response with `WWW-Authenticate` header is received. This option does not affect requests sent
* from the browser.
*/
Expand Down Expand Up @@ -15632,7 +15632,7 @@ export interface APIRequest {
origin?: string;

/**
* Whether to send `Authorization` header with the first API request. By deafult, the credentials are sent only when
* Whether to send `Authorization` header with the first API request. By default, the credentials are sent only when
* 401 (Unauthorized) response with `WWW-Authenticate` header is received. This option does not affect requests sent
* from the browser.
*/
Expand Down Expand Up @@ -16783,7 +16783,7 @@ export interface Browser extends EventEmitter {
origin?: string;

/**
* Whether to send `Authorization` header with the first API request. By deafult, the credentials are sent only when
* Whether to send `Authorization` header with the first API request. By default, the credentials are sent only when
* 401 (Unauthorized) response with `WWW-Authenticate` header is received. This option does not affect requests sent
* from the browser.
*/
Expand Down Expand Up @@ -17677,7 +17677,7 @@ export interface Electron {
origin?: string;

/**
* Whether to send `Authorization` header with the first API request. By deafult, the credentials are sent only when
* Whether to send `Authorization` header with the first API request. By default, the credentials are sent only when
* 401 (Unauthorized) response with `WWW-Authenticate` header is received. This option does not affect requests sent
* from the browser.
*/
Expand Down Expand Up @@ -20344,7 +20344,7 @@ export interface HTTPCredentials {
origin?: string;

/**
* Whether to send `Authorization` header with the first API request. By deafult, the credentials are sent only when
* Whether to send `Authorization` header with the first API request. By default, the credentials are sent only when
* 401 (Unauthorized) response with `WWW-Authenticate` header is received. This option does not affect requests sent
* from the browser.
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright/src/common/esmLoaderHost.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export async function incorporateCompilationCache() {
if (!loaderChannel)
return;
// This is needed to gather dependency information from the esm loader
// that is populated from the resovle hook. We do not need to push
// that is populated from the resolve hook. We do not need to push
// this information proactively during load, but gather it at the end.
const result = await loaderChannel.send('getCompilationCache', {});
addToCompilationCache(result.cache);
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright/src/common/fixtures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export function fixtureParameterNames(fn: Function | any, location: Location, on
return fn[signatureSymbol];
}

export function inheritFixutreNames(from: Function, to: Function) {
export function inheritFixtureNames(from: Function, to: Function) {
(to as any)[signatureSymbol] = (from as any)[signatureSymbol];
}

Expand Down
2 changes: 1 addition & 1 deletion packages/playwright/src/matchers/toMatchSnapshot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class SnapshotHelper {
++snapshotNames.anonymousSnapshotIndex,
].join(' ');
inputPathSegments = [sanitizeForFilePath(trimLongString(fullTitleWithoutSpec)) + '.' + anonymousSnapshotExtension];
// Trim the output file paths more aggresively to avoid hitting Windows filesystem limits.
// Trim the output file paths more aggressively to avoid hitting Windows filesystem limits.
this.outputBaseName = sanitizeForFilePath(trimLongString(fullTitleWithoutSpec, windowsFilesystemFriendlyLength)) + '.' + anonymousSnapshotExtension;
} else {
// We intentionally do not sanitize user-provided array of segments, but for backwards
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright/src/reporters/merge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ async function extractAndParseReports(dir: string, shardFiles: string[], interna
fileName = reportNames.makeUnique(fileName);
let parsedEvents = parseCommonEvents(content);
// Passing reviver to JSON.parse doesn't work, as the original strings
// keep beeing used. To work around that we traverse the parsed events
// keep being used. To work around that we traverse the parsed events
// as a post-processing step.
internalizer.traverse(parsedEvents);
const metadata = findMetadata(parsedEvents, file);
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright/src/worker/fixtureRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class Fixture {
this.failed = true;
return;
}
// Fixture teardown is root => leafs, when we need to teardown a fixture,
// Fixture teardown is root => leaves, when we need to teardown a fixture,
// it recursively tears down its usages first.
dep._usages.add(this);
// Don't forget to decrement all usages when fixture goes.
Expand Down
4 changes: 2 additions & 2 deletions packages/playwright/src/worker/workerMain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import { applyRepeatEachIndex, bindFileSuiteToProject, filterTestsRemoveEmptySui
import { PoolBuilder } from '../common/poolBuilder';
import type { TestInfoError } from '../../types/test';
import type { Location } from '../../types/testReporter';
import { inheritFixutreNames } from '../common/fixtures';
import { inheritFixtureNames } from '../common/fixtures';
import { type TimeSlot, TimeoutManagerError } from './timeoutManager';

export class WorkerMain extends ProcessRunner {
Expand Down Expand Up @@ -490,7 +490,7 @@ export class WorkerMain extends ProcessRunner {
const result = await modifier.fn(fixtures);
testInfo[modifier.type](!!result, modifier.description);
};
inheritFixutreNames(modifier.fn, fn);
inheritFixtureNames(modifier.fn, fn);
runnables.push({
title: `${modifier.type} modifier`,
location: modifier.location,
Expand Down
4 changes: 2 additions & 2 deletions packages/playwright/types/test.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4233,7 +4233,7 @@ export interface TestType<TestArgs extends KeyValue, WorkerArgs extends KeyValue
* });
* ```
*
* Alternatively, you can delcare a hook **with a title**.
* Alternatively, you can declare a hook **with a title**.
*
* ```js
* // example.spec.ts
Expand Down Expand Up @@ -4283,7 +4283,7 @@ export interface TestType<TestArgs extends KeyValue, WorkerArgs extends KeyValue
* });
* ```
*
* Alternatively, you can delcare a hook **with a title**.
* Alternatively, you can declare a hook **with a title**.
*
* ```js
* // example.spec.ts
Expand Down
2 changes: 1 addition & 1 deletion tests/components/ct-vue-cli/tests/events/events.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ test('emit an submit event when the button is clicked', async ({ mount }) => {
expect(messages).toEqual(['hello']);
});

test('emit a falltrough event when the button is double clicked', async ({ mount }) => {
test('emit a fallthrough event when the button is double clicked', async ({ mount }) => {
const messages: string[] = [];
const component = await mount(Button, {
props: {
Expand Down
2 changes: 1 addition & 1 deletion tests/components/ct-vue-cli/tests/events/events.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ test('emit an submit event when the button is clicked', async ({ mount }) => {
expect(messages).toEqual(['hello']);
});

test('emit a falltrough event when the button is double clicked', async ({ mount }) => {
test('emit a fallthrough event when the button is double clicked', async ({ mount }) => {
const messages: string[] = [];
const component = await mount(
<Button
Expand Down
2 changes: 1 addition & 1 deletion tests/components/ct-vue-vite/tests/events/events.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ test('emit a submit event when the button is clicked', async ({ mount }) => {
expect(messages).toEqual(['hello']);
});

test('emit a falltrough event when the button is double clicked', async ({ mount }) => {
test('emit a fallthrough event when the button is double clicked', async ({ mount }) => {
const messages = [];
const component = await mount(Button, {
props: {
Expand Down
2 changes: 1 addition & 1 deletion tests/components/ct-vue-vite/tests/events/events.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ test('emit a submit event when the button is clicked', async ({ mount }) => {
expect(messages).toEqual(['hello']);
});

test('emit a falltrough event when the button is double clicked', async ({ mount }) => {
test('emit a fallthrough event when the button is double clicked', async ({ mount }) => {
const messages: string[] = [];
const component = await mount(Button, {
props: {
Expand Down
2 changes: 1 addition & 1 deletion tests/components/ct-vue-vite/tests/events/events.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ test('emit a submit event when the button is clicked', async ({ mount }) => {
expect(messages).toEqual(['hello']);
});

test('emit a falltrough event when the button is double clicked', async ({ mount }) => {
test('emit a fallthrough event when the button is double clicked', async ({ mount }) => {
const messages: string[] = [];
const component = await mount(
<Button
Expand Down
6 changes: 3 additions & 3 deletions tests/config/testserver/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import ws from 'ws';
import zlib, { gzip } from 'zlib';
import { createHttpServer, createHttpsServer } from '../../../packages/playwright-core/lib/utils/network';

const fulfillSymbol = Symbol('fullfil callback');
const fulfillSymbol = Symbol('fulfil callback');
const rejectSymbol = Symbol('reject callback');

const gzipAsync = util.promisify(gzip.bind(zlib));
Expand Down Expand Up @@ -288,8 +288,8 @@ export class TestServer {
}

waitForWebSocketConnectionRequest() {
return new Promise<http.IncomingMessage & { headers: http.IncomingHttpHeaders }>(fullfil => {
this._wsServer.once('connection', (ws, req) => fullfil(req));
return new Promise<http.IncomingMessage & { headers: http.IncomingHttpHeaders }>(fulfil => {
this._wsServer.once('connection', (ws, req) => fulfil(req));
});
}

Expand Down

0 comments on commit e95c462

Please sign in to comment.