Changed libraries to start using Java 17 and not Kotlin #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjoman
requested changes
Aug 17, 2023
...gsgeneration/src/main/java/com/theagilemonkeys/ellmental/embeddingsgeneration/Embedding.java
Outdated
Show resolved
Hide resolved
...s/embeddingsstore/src/main/java/com/theagilemonkeys/ellmental/embeddingsstore/Embedding.java
Outdated
Show resolved
Hide resolved
embedding store functionality
unused files
mnlx
commented
Aug 17, 2023
| .url(url + path) | ||
| .header("accept", "application/json") | ||
| .header("content-type", "application/json") | ||
| .header("Api-Key", "1c13987f-1d13-4373-8655-f739089de6af") |
There was a problem hiding this comment.
This API key is from my personal account, I'll delete them once I implement dotenv or env variables.
mnlx
commented
Aug 17, 2023
|
|
||
|
|
||
|
|
||
| //class Schema { |
juanjoman
reviewed
Aug 17, 2023
| public List<Integer> indices; | ||
| public List<Integer> values; | ||
|
|
||
| // Getters and setters |
There was a problem hiding this comment.
You can have a look at lombok if you want to get rid of a lot of code 😋 -> https://www.baeldung.com/intro-to-project-lombok
There was a problem hiding this comment.
I heard of this library before, never new it was used for this. So much easier. I'm going to create a task to start using Lombok.
NickSeagull
approved these changes
Aug 17, 2023
adrian-lorenzo
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.