Fix-569: set Laptime to NaT for drivers crashed in lap 1. Assign NaN position. #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to drivers with NaT time.
|
I'll take a look at the failing tests. |
|
The chained I'm also not sure if we can really set 'Time' to |
…s are FastF1Generated.
AND2797
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a special case in _load_laps_data to create data for drivers crashed in lap1. In that, previously we were assigning
data['Time'].min()this was the source of the bug.I modified two things:
assign time as pd.NaT for crashed drivers.
And while generating the position of drivers for the lap, assign np.NaN to drivers who have NaT/NaN times.