Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing parameter for RenderLargeRectangles #100

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Changing parameter for RenderLargeRectangles #100

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
323d807
Parameter fixed
theilgaz Jun 2, 2021
439e411
Bad example fixed
theilgaz Jun 3, 2021
e6ad4db
Bad example fixed
theilgaz Jun 3, 2021
880cea2
Typo fixed
theilgaz Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1830,7 +1830,8 @@ class Employee

- [S: Single Responsibility Principle (SRP)](#single-responsibility-principle-srp)
- [O: Open/Closed Principle (OCP)](#openclosed-principle-ocp)
- [L: Liskov Substitution Principle (LSP)](#liskov-substitution-principle-lsp)
- [L:
v Substitution Principle (LSP)](#liskov-substitution-principle-lsp)
Copy link

@dmitryvhf dmitryvhf Jun 3, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excessed change. And new error.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I use search filter to find faster, but then I see error. I fixed this in here.

- [I: Interface Segregation Principle (ISP)](#interface-segregation-principle-isp)
- [D: Dependency Inversion Principle (DIP)](#dependency-inversion-principle-dip)

Expand Down Expand Up @@ -2077,7 +2078,7 @@ class Square : Rectangle
}
}

Drawable RenderLargeRectangles(Rectangle rectangles)
Drawable RenderLargeRectangles(Rectangle[] rectangles)
{
foreach (rectangle in rectangles)
{
Expand Down Expand Up @@ -2141,7 +2142,7 @@ class Square : ShapeBase
}
}

Drawable RenderLargeRectangles(Rectangle rectangles)
Drawable RenderLargeRectangles(Rectangle[] rectangles)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make same into 2080 line, for "Bad" example

{
foreach (rectangle in rectangles)
{
Expand Down