Add option to validate templates using jinja2schema #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kx-chen
force-pushed
the
jinja2schema-validation
branch
2 times, most recently
from
75b77fb
to
cb41734
Compare
jayvdb
requested changes
Dec 17, 2018
statik/utils.py
Outdated
| % (item, template)) | ||
| except Exception as e: | ||
| logger.warning( | ||
| "Template validation failed (likely an issue with jinja2schema): %s: %s", |
There was a problem hiding this comment.
move the except so that it only catches errors in one line result = to_json_schema(infer(stripped_template)) and then change the warning to explicitly indicate the problem is within jinja2schema. Something like "Template inspection using jinja2schema failed: .."
Usually, only do one thing within try/except blocks. Then add another exception block to catch the next type of error.
Use jinja2schema to validate templates when --validate-templates is passed in. Closes thanethomson#99
kx-chen
force-pushed
the
jinja2schema-validation
branch
from
cb41734
to
3f93889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use jinja2schema to validate templates when
--validate-templatesis passed in.
Closes #99