Correctly parse reconciled transactions #53
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. It looks like you have been able to update it so that the value is parsed, but is not actually being used in the application. That should be sufficient for at least making files with this reconciliation flag parsable. It looks like there are some failures in the tests, but I am not sure if they are introduced by this change or not. It's been a very long time since I have worked in this project. |
|
Oh, you're right, I never ran the full test suite. Let me check that out. If they turn out to be unrelated, I'll push those in a separate PR and rebase this on top of that (or at least that how I think it's done). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9 partially. I'm still unsure about how to use this in parser.ts and would appreciate some guidance.
My tests also might not be the best, would appreciate suggestions.