adding treatment for ORs & ANDs #1100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix the issue I reported (#1092). I decided to go with the behaviour that any side of the OR having a relevant permission is enough to generate a security requirement
The mypy linting reports some errors that I am unable to even figure out why they are errors. I tested the code both with the
./runtests.pyscript and using the new code on a project I created for testing, and both work fine.P.S.: Although I fixed the issue I reported, the behaviour of the function as it is (and as it was) feels a little funky. It feels weird that it returns on the first permission that matches any of the three relevant ones (
TokenMatchesOASRequirements,IsAuthenticatedOrTokenHasScopeorTokenHasScope), but I'm not really familiar with Swagger nor OpenAPI in general to have an informed opinion on the subject.