Move Shell provisioner data to provisioner as well #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be rebased? We're planning on moving Chef out of core like other provisioners so this lines u well either way. |
paracycle
force-pushed
the
shell-suite-variables
branch
from
b47a088
to
6671729
Compare
|
That's great news. I did a quick mechanical rebase of the original commit but didn't have time to check if anything else needs updating in the new code as well. Please let me know how you want to proceed. |
|
I kicked the build to see if this will work but we will need it rebased again to get it in but I'd still love to see this in. |
Each test suite should be able to specify its own `script` and `data_path` if the provisioner in use is the Shell provisioner.
paracycle
force-pushed
the
shell-suite-variables
branch
from
6671729
to
e4673ee
Compare
|
@cheeseplus I rebased the commit on the latest master, however, it seems there is a problem with |
|
needs to be reviewed again post #1382 merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each test suite should be able to specify its own
scriptanddata_pathif the provisioner in use is the Shell provisioner.