adding defaults for chef_omnibus_root for windows and unix-like/linux systems #1619
Conversation
tarcinil
force-pushed
the
patch/923
branch
2 times, most recently
from
40fa9f0
to
8dc6de4
Compare
… systems This work patches test-kitchen#923 so that the issue will stop bugging people, and we can discuss implementing mixlib-install but that has downstream affects against cinc.
| @@ -44,6 +44,13 @@ module Provisioner | |||
| class ChefBase < Base | |||
| default_config :require_chef_omnibus, true | |||
| default_config :chef_omnibus_url, "https://omnitruck.chef.io/install.sh" | |||
| default_config :chef_omnibus_root do |provisioner| | |||
| if provisioner.powershell_shell? | |||
| "/opt/chef" # I know that we don't need this, but it leaves things flexible. | |||
There was a problem hiding this comment.
Any reason not to set this to the Windows default of "$env:systemdrive\\opscode\\chef"?
There was a problem hiding this comment.
I based that on content that I had seen inside of the spec tests.
spec/kitchen/provisioner/chef_base_spec.rb#L604
which looks to expect the same path as unix-like/linux systems. I did contemplate using an elsif to provisioner.windows_os? to "$env:systemdrive\\opscode\\chef" entry.
There was a problem hiding this comment.
that should be c:\opscode\chef though not /opt/chef for windows
|
As I am setting the default, anything done in the later functions "should" overload the default_config. I have been thinking adding additional unit tests that would overload this using lets say Cinc as an example. |
This work patches #923 so that the issue will stop bugging people, and we can discuss implementing mixlib-install but that has downstream affects against cinc.