Add instance name to download path when downloading files #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that's all the tests passing... the rest of the CI appears to be failing much earlier in the chain, so I don't think it's related to my changes. Feel free to correct me if I'm wrong! 😊 💖 |
If the same download path is used for all instances, it may prove problematic, especially if it is configured to download specific files; the file would be overwritten. Adding the instance name to the path allows the feature to be used by multiple instances in succession without potentially overwriting files.
vexx32
force-pushed
the
instance-named-download-folders
branch
from
2cc03bb
to
27e31c1
Compare
|
From what I can see from the logs, I don't think the CI error is related to this PR. Give me a ping if anything more is needed here. 🙂 |
lamont-granquist
added
the
Breaking Change
|
this is probably the correct thing to do, but in the event someone has figured out this works fine for single instances they may be happily using it and this would break any scripts they have build wrapping it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same download path is used for all instances, it may prove problematic, especially if it is configured to download specific files; the file would be overwritten and the data lost.
Adding the instance name to the path allows the feature to be used by multiple instances in succession without potentially overwriting files.
/cc @tas50 @smurawski @gep13