Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for overlaps to validate top left #1366

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Jun 2, 2023

Summary

If top and left keywords are used incorrectly they can cause invalid overlaps which can lead to layout errors.
This adds validation to check that the top and left keywords do not guarantee a layout is impossible.

Details

  • check if objects in the same container will definitely overlap based on their top and left keywords and their initial dimensions
  • Note: if container objects need to grow past their initial dimensions to fit descendants during layout they can still end up overlapping with to top and left, causing a layout error.

@gavin-ts gavin-ts requested a review from alixander June 2, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant