Fix: Let Docker image be built correctly for non-amd64 platforms #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the Docker image on a platform such as arm64, the generated binary is instead located inside the `/go/src/terraform-docs/bin/linux-arm64/` folder, meaning the second stage of the Docker image build fails. This fixes that. Signed-off-by: Jeppe Fihl-Pearson <[email protected]>
Tenzer
force-pushed
the
non-amd64-dockerfile
branch
from
84fc7df
to
3c44c58
Compare
Signed-off-by: Brittan DeYoung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the Docker image on a platform such as arm64, the generated binary is instead located inside the
/go/src/terraform-docs/bin/linux-arm64/folder, meaning the second stage of the Docker image build fails.This fixes that.
I have:
make test.How has this code been tested
I have built the Docker image on an arm64 platform and verified that the
terraform-docsbinary inside of it is built for the current platform.