Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dynamic block to support job_workflow_ref #488

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

benchunghpe
Copy link

@benchunghpe benchunghpe commented May 13, 2024

Description

This PR adds a dynamic block and optional variable to support specifying a set of allowed job_workflow_ref to allow fine-grained access to a github OIDC role.

Motivation and Context

Currently, the github OIDC role module doesn't support passing job_workflow_ref to explicitly allow a limited set of workflows to assume an AWS IAM role through OIDC. The potential impact of this is that using this module, someone would be able to fork one of our github workflows, change the business logic and still have no issues assuming the IAM role.

At HPE, we have a local version of this module which allows us to say "only allow a workflow to assume this IAM role if it's coming from the main branch of our organisation-wide reusable-workflows", which isn't possible in the main branch of this module due to the lack of support.

Breaking Changes

n/a, this adds a new optional variable so should extend the current functionality for those who require this feature

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • This is running in production at HPE
  • I have executed pre-commit run -a on my pull request

@benchunghpe benchunghpe changed the title feat(github_oidc_role) Add dynamic block to support job_workflow_ref feat:Add dynamic block to support job_workflow_ref May 13, 2024
@benchunghpe benchunghpe changed the title feat:Add dynamic block to support job_workflow_ref feat: Add dynamic block to support job_workflow_ref May 13, 2024
@benchunghpe
Copy link
Author

This should be ready for review when someone's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant