feat: Add support for STS Session Tags #480
Open
+56
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatmcgav
force-pushed
the
feat/oidc-trust-policy
branch
from
a9b50a0
to
bdbf18a
Compare
|
this looks like you are looking for the https://github.com/terraform-aws-modules/terraform-aws-iam/tree/master/modules/iam-role-for-service-accounts-eks instead - using that sub-module, is this change still warranted? I'm thinking no |
|
Hey @bryantbiggs ... So I think this change is still valid, as I'm using session tags in combination with an external OIDC provider, in this case env0. Docs are here: https://docs.env0.com/docs/oidc-with-aws#custom-claims-with-aws-session-tags-optional |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
@bryantbiggs / @antonbabenko Any chance of a review on this one? 👍 |
This commit adds support to the `iam-assumable-role-with-oidc` module for enabling and configuring STS Session tags on the role trust policy. Docs: https://docs.aws.amazon.com/IAM/latest/UserGuide/id_session-tags.html
fatmcgav
force-pushed
the
feat/oidc-trust-policy
branch
from
bdbf18a
to
799ec71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support to the
iam-assumable-role-with-oidcmodulefor enabling and configuring STS Session tags on the role trust policy.
Docs: https://docs.aws.amazon.com/IAM/latest/UserGuide/id_session-tags.html
Motivation and Context
STS session tags allow for additional control when using the
AssumeRoleWithWebIdentityauthentication call.Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request