Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karpenter): Allow only https in sqs #2975

Closed

Conversation

ksbde
Copy link

@ksbde ksbde commented Mar 19, 2024

Description

I would like to deny access to AWS SQS through HTTP by AWS SQS access policy due to security reasons.

Motivation and Context

SQS security best practices

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@ksbde ksbde changed the title fix(karpenter): allow only https in sqs fix(karpenter): Allow only https in sqs Mar 19, 2024
@bryantbiggs
Copy link
Member

if the upstream Karpenter project supports this, then we can support it here as well

@ksbde
Copy link
Author

ksbde commented Mar 19, 2024

I've tested with latest version, everything is ok.

@bryantbiggs
Copy link
Member

if the upstream project states that it is supported, or its shown in their example, then we can support it. but we do not want to diverge - thats caused pain in the past with things like IAM policies

@ksbde
Copy link
Author

ksbde commented Mar 19, 2024

I've created an additional issue to the karpenter.
Let's see what will come out of this. Ok?

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 19, 2024
@github-actions github-actions bot removed the stale label Apr 20, 2024
@bryantbiggs
Copy link
Member

closing for now until upstream guidance is updated

@bryantbiggs bryantbiggs closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants