feat: Define instance types on launch template to avoid node group creation and deletion when changing instance_types value #2530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace aws_eks_node_group.instance_types by aws_launch_template.instance_requirements.allowed_instance_types.
If possible i'll need your help to test it.
Motivation and Context
This will replace a node group creation, then old nodegroup deletion by a simple update of the launch template on the nodegroup
This is very useful because of this issue (redacted) and will prevent downtime for instance_types change use case.
Breaking Changes
No breaking change it allow the same as before, but it will also allow specifying more than before like :
aws documentation see AllowedInstanceTypes part
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request