Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Define instance types on launch template to avoid node group creation and deletion when changing instance_types value #2530

Closed
wants to merge 1 commit into from

Conversation

noony
Copy link
Contributor

@noony noony commented Mar 21, 2023

Description

Replace aws_eks_node_group.instance_types by aws_launch_template.instance_requirements.allowed_instance_types.

If possible i'll need your help to test it.

Motivation and Context

This will replace a node group creation, then old nodegroup deletion by a simple update of the launch template on the nodegroup

This is very useful because of this issue (redacted) and will prevent downtime for instance_types change use case.

Breaking Changes

No breaking change it allow the same as before, but it will also allow specifying more than before like :

instance_types = ["c5*", "c6*"]

aws documentation see AllowedInstanceTypes part

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@noony noony changed the title Define instance types on launch template to avoid node group creation and deletion when changing instance_types value feat: Define instance types on launch template to avoid node group creation and deletion when changing instance_types value Mar 21, 2023
…eation and deletion when changing instance_types value
@bryantbiggs
Copy link
Member

bryantbiggs commented Mar 21, 2023

  1. Why would this solve the linked issue?
  2. What do you use for autoscaling the nodes in your data plane?
  3. What version of Kubernetes are you currently using?

@noony
Copy link
Contributor Author

noony commented Mar 22, 2023

Sorry i just tested and node group is managing asg behind in order to set instance types and not launch templates. I'm closing.

@noony noony closed this Mar 22, 2023
@noony noony deleted the instance-types-launch-template branch March 22, 2023 15:39
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants