Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Autoscaling schedule for EKS managed node group #2504

Conversation

ducminhle
Copy link
Contributor

@ducminhle ducminhle commented Mar 4, 2023

Description

Allow settings autoscaling schedule for eks_managed_node_group module

Motivation and Context

We can set autoscaling schedules for self_managed_node_group, but we didn't have autoscaling schedules config for eks_managed_node_group.
I added 2 variables create_schedule, schedules and resource aws_autoscaling_schedule for eks-managed-node-group module

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

I deployed example: eks_managed_node_group on AWS and autoscaling schedule has been added
image
image
image

  • I have executed pre-commit run -a on my pull request

@ducminhle ducminhle force-pushed the add-eks-managed-node-group-autoscaling-schedule branch from affba60 to bd30815 Compare March 4, 2023 06:51
@ducminhle ducminhle changed the title feat: add autoscaling schedule for eks managed node group feat: Add Autoscaling schedule for EKS managed node group Mar 4, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs merged commit 4a2523c into terraform-aws-modules:master Mar 31, 2023
17 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 31, 2023
## [19.12.0](v19.11.0...v19.12.0) (2023-03-31)

### Features

* Add Autoscaling schedule for EKS managed node group ([#2504](#2504)) ([4a2523c](4a2523c))
@antonbabenko
Copy link
Member

This PR is included in version 19.12.0 🎉

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants