Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in to_onnx.py #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix typo in to_onnx.py #42

wants to merge 1 commit into from

Conversation

bibs2091
Copy link

Add size to the last part of the code, otherwise the max_sizes wont be the same resulting in weird boxes positions:
Screenshot 2022-07-20 at 16 53 50

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 20, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.55%.

Quality metrics Before After Change
Complexity 1.74 ⭐ 1.77 ⭐ 0.03 👎
Method Length 99.50 🙂 101.67 🙂 2.17 👎
Working memory 8.84 🙂 8.87 🙂 0.03 👎
Quality 64.35% 🙂 63.80% 🙂 -0.55% 👎
Other metrics Before After Change
Lines 143 151 8
Changed files Quality Before Quality After Quality Change
converters/to_onnx.py 64.35% 🙂 63.80% 🙂 -0.55% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
converters/to_onnx.py main 4 ⭐ 241 ⛔ 11 😞 49.88% 😞 Try splitting into smaller methods. Extract out complex expressions
converters/to_onnx.py M.forward 0 ⭐ 121 😞 7 🙂 72.87% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant