Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: Chafa #7491

Merged
3 commits merged into from Sep 9, 2021
Merged

New Package: Chafa #7491

3 commits merged into from Sep 9, 2021

Conversation

Yonle
Copy link
Contributor

@Yonle Yonle commented Sep 8, 2021

Fixed mess of #7488

@ghost
Copy link

ghost commented Sep 9, 2021

Does it provide something new besides what termimage, timg, jp2a can do?

@Yonle
Copy link
Contributor Author

Yonle commented Sep 9, 2021

Yes. There's a difference between those package with Chafa

@ghost
Copy link

ghost commented Sep 9, 2021

Which exactly?

@Yonle
Copy link
Contributor Author

Yonle commented Sep 9, 2021

Gah. Can't tell the difference between those package with Chafa. But there's also a test:
Screenshot_2021_0908_110314
Screenshot_2021_0908_110609

@ghost
Copy link

ghost commented Sep 9, 2021

timg has similar, if not exact or even better, image quality. Also supports animations and video output (quite smooth btw). Additionally timg has image gallery feature. So I'm curious, why need another one image viewer if it doesn't add anything new?

https://github.com/termux/termux-packages/blob/master/CONTRIBUTING.md#packaging-policy

...requested packages should met these conditions:

  • Not serving duplicated functionality

    Please avoid submitting packages which duplicate functionality of already present ones

@Yonle
Copy link
Contributor Author

Yonle commented Sep 9, 2021

After some search, Chafa, has a feature like

  • watch that used to watch a file then change output whenever the file content is changed
  • color mode which can reduces how many color thatvwe should view
  • There's also a way to change output format like iterm, kitty, sixel, and more so like that.
  • There's also a option to invert a video.

Well, maybe opening this PR to put some alternative.

@ghost
Copy link

ghost commented Sep 9, 2021

Ok, merging it now. Just know that I'm against any duplicate stuff, unless there is a strong reason to have it added. Repository size is very close to go beyond the expected disk usage (50% for .deb packages):

--[censored]--:~$ df -h
Filesystem      Size  Used Avail Use% Mounted on
...
/dev/vda1        32G   17G   15G  52% /
...
--[censored]--:~$ du -hs /srv/termux-host/aptly-root/
12G     /srv/termux-host/aptly-root/

I really don't know what will be if we decide will add repository with Android APK package format (for termux/termux-app#2155), as that effectively will use 2x more space than we're using now.

So next time please add things that will be useful for everyone and not because you've just discovered it and was able to compile. There are still a lot of packages pending to be added.

@ghost ghost merged commit 80dd781 into termux:master Sep 9, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant