Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new package: go-musicfox #20115

Merged
merged 1 commit into from May 14, 2024
Merged

new package: go-musicfox #20115

merged 1 commit into from May 14, 2024

Conversation

anhoder
Copy link
Contributor

@anhoder anhoder commented May 12, 2024

new packages:

@TomJo2000
Copy link
Member

Let's quickly check that against the package request template.


Why is it worth to add this package?

A netease music player in terminal.

Home page URL

https://github.com/go-musicfox/go-musicfox

Source code URL

https://github.com/go-musicfox/go-musicfox

Packaging policy acknowledgement

  • The project is actively developed.

  • The project has existing packages and is "well known".

  • Licensed under an open source license.

  • Not available through a language package manager: pip, npm, cpan, cargo, etc.

  • Not taking up too much disk space (< 100MiB per architecture, exceptions can be made)

  • Not duplicating the functionality of existing packages.

  • Not serving hacking, malware, phishing, spamming, spying, ddos functionality.

  • I certify that I have read Termux Packaging Policy and understand that my request will be denied if it is found lacking.

Additional information

N/A


Looks all good at a glance, I'll take a look at the build script next.

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine, there's a couple minor things to clean up.

Once you are done with that, please squash your commits, since we prefer keeping package additions as a single commit.


Thank you for taking the time to package this project and contribute to Termux.

packages/go-musicfox/build.sh Outdated Show resolved Hide resolved
packages/go-musicfox/build.sh Outdated Show resolved Hide resolved
packages/go-musicfox/build.sh Outdated Show resolved Hide resolved
packages/go-musicfox/build.sh Outdated Show resolved Hide resolved
packages/go-musicfox/build.sh Outdated Show resolved Hide resolved
packages/go-musicfox/build.sh Show resolved Hide resolved
@anhoder
Copy link
Contributor Author

anhoder commented May 14, 2024

@TomJo2000 I have made the changes, please take a look for me again.

@TomJo2000 TomJo2000 self-requested a review May 14, 2024 15:52
packages/go-musicfox/build.sh Show resolved Hide resolved
@TomJo2000 TomJo2000 merged commit dd27e47 into termux:master May 14, 2024
bigbio2002 pushed a commit to bigbio2002/termux-packages that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants