Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed: Bump Robolectric to 4.10 #3345

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Apr 16, 2023

@utzcoz
Copy link
Contributor Author

utzcoz commented Apr 16, 2023

Friendly ping @agnostic-apollo for reviewing.

@agnostic-apollo
Copy link
Member

Thanks robolectric-dependabot! Our one test dependent on it appreciates it. ;)

@agnostic-apollo agnostic-apollo merged commit 93eafff into termux:master Apr 16, 2023
4 checks passed
@utzcoz utzcoz deleted the bump-robolectric-to-4.10 branch April 17, 2023 00:36
@utzcoz
Copy link
Contributor Author

utzcoz commented Apr 17, 2023

@agnostic-apollo Thanks for reviewing. Oh, you found out who I am. :)

@agnostic-apollo
Copy link
Member

You are very welcome. lolz, yeah, I was curious why you were sending just pulls for robolectric updates. ;)

@utzcoz
Copy link
Contributor Author

utzcoz commented Apr 17, 2023

I was curious why you were sending just pulls for robolectric updates.

I am the co-maintainer of the Robolectric, and I want other repositories to use the latest Robolectric as quick as possible. So I will send Robolectric updates PR to some repositories that I know, I use, and I think is important manually if they don't use tools like dependabot to update Robolectric dependencies automatically. Actually, I became a user of the Termux some years ago.

@agnostic-apollo
Copy link
Member

Ah, cool. More tests are planned for future so robolectric would hopefully be of more use and would then require keeping up to date with updates even more and so would probably require our robolectric-dependabot.

That's great. Hopefully, termux has been treating you nice.

@utzcoz
Copy link
Contributor Author

utzcoz commented Apr 19, 2023

Cool. The Robolectric can help a lot for JVM tests with nice fidelity and great performance. When the termux-app tries more tests with Robolectric, and think there are something that I can help, feel free to contact me.

@agnostic-apollo
Copy link
Member

Yeah, will look into writing more tests when termux-shared library is split. Currently, I only write on-device tests for critical or security related stuff like filesystem, unfortunately have limited time to write tests. Thanks for the offer, will surely keep it in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants