Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply changes to attach_debug_apks_to_release as requested #3253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thunder-coding
Copy link
Member

@thunder-coding thunder-coding commented Feb 16, 2023

See #3241

Once this PR is approved, a new release of upload-release-actions will be created, and the last commit will be reworded.

Test release:
https://github.com/thunder-coding/termux-app/releases/tag/v0.118.6

@agnostic-apollo
Copy link
Member

Thanks for the changes.

However, read the specs again linked via #3241 (comment)

There must be a space followed by a space for text mode or * for binary mode between hash and filename. The sha265sum and md5sum defaults to text mode, so there are two spaces. You are adding a tab instead for some reason.

https://www.gnu.org/software/coreutils/manual/html_node/md5sum-invocation.html

https://www.gnu.org/software/coreutils/manual/html_node/sha2-utilities#sha2-utilities

termux/upload-release-action@5f5653d

I don't know what mode node crypto internally uses compared with gnu utils, which would have to be checked too. Apparently, in text mode, \r\n may get translated to \n.

https://unix.stackexchange.com/questions/127959/md5sum-command-binary-and-text-mode/127961#127961

https://stackoverflow.com/questions/17988090/what-are-the-differences-between-md5-binary-mode-and-text-mode

https://stackoverflow.com/questions/70360822/python-binary-mode-vs-encoding-and-its-sha256

Hopefully for following, specially with globs, there are duplicate file name checks since different (sub)directories could have files with same basenames.

termux/upload-release-action@422a9a2

@agnostic-apollo
Copy link
Member

Also, follow commit guidelines.

https://github.com/termux/termux-app#For-Maintainers-and-Contributors

Also, despite the fixes to upload-release-action for other termux repos, I still haven't decided if adding an external action dependency without any advantages should be done, specially something written in frickin' node/javascript ;)

Maybe other termux devs can give their opinion. Technically, termux-packages uses it for packages and bootstrap, so any effects would get translated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants