Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed!: Bump Robolectric to 4.9.2 #3217

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Jan 28, 2023

No description provided.

@utzcoz
Copy link
Contributor Author

utzcoz commented Jan 31, 2023

Hi @agnostic-apollo @Grimler91 , could you help to give a review to this PR? Thanks.

@agnostic-apollo
Copy link
Member

Use Changed type in commit message, otherwise is fine.

https://github.com/termux/termux-app#for-maintainers-and-contributors

@utzcoz utzcoz changed the title Bump Robolectric to 4.9.2 Changed!: Bump Robolectric to 4.9.2 Feb 4, 2023
@utzcoz
Copy link
Contributor Author

utzcoz commented Feb 4, 2023

@agnostic-apollo Thanks. I added Changed!: to the commit message.

@utzcoz
Copy link
Contributor Author

utzcoz commented Mar 20, 2023

Friendly ping @agnostic-apollo for reviewing.

@agnostic-apollo
Copy link
Member

Thanks.

Bumping roboelectric version is not a breaking change, so ! should not be added. And in future, do not use merge commits to sync with master, learn to use rebase.

https://matrix.to/#/!rrHhKvLYtBVDOISphu:gitter.im/$rloCNAUzgDa2pSVbT_FK5QPMME2njQ3do9KCONET2S4?via=gitter.im&via=t2bot.io&via=matrix.org

@utzcoz utzcoz deleted the robolectric-4.9.2 branch March 22, 2023 06:22
@utzcoz
Copy link
Contributor Author

utzcoz commented Mar 22, 2023

@agnostic-apollo Thanks. I will take attention to these rules next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants