Individual zoom setting based on display ID #3208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babaric-dev
force-pushed
the
individual-zoom
branch
from
b94aea2
to
b1ec485
Compare
|
Will this merge? |
|
Yes, looks fine, will test myself later. |
This comment was marked as spam.
This comment was marked as spam.
|
@agnostic-apollo Could you please review and approve my PR? |
|
Like I said in the other pull that preferences files have been moved, so you will have to wait till I push my local changes. |
babaric-dev
force-pushed
the
individual-zoom
branch
from
b1ec485
to
ff2d80a
Compare
babaric-dev
force-pushed
the
individual-zoom
branch
from
ff2d80a
to
bea755b
Compare
babaric-dev
force-pushed
the
individual-zoom
branch
from
bea755b
to
f22fde2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR kind of solves #3119.
Originally, every zoom change made is stored in the
KEY_FONTSIZEkey inSharedPreferences.In this PR, it uses the display ID as a key to store the setting. The key is
KEY_FONTSIZE+ display number in string representation. The only exception is for the primary display (Display.DEFAULT_DISPLAY), which usesKEY_FONTSIZE.Suppose
Display.DEFAULT_DISPLAYis 0 andKEY_FONTSIZEis "fontsize" Here are some examples:I tested the code. It works even during runtime switches between phone / DeX.