Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LastPendingIntentRequestCode support to TermuxAPIAppSharedPreferences #3043

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

EduardDurech
Copy link
Contributor

@EduardDurech EduardDurech commented Oct 12, 2022

@agnostic-apollo
Copy link
Member

Enabled commitToFile. Also ideally pull requests shouldn't be sent from the master branch, create separate branche for each pull, useful if multiple pull requests need to be sent and you won't have to force push master branch on your repo after merging and can just delete pull branch.

@agnostic-apollo
Copy link
Member

Also ideally constant should have been added to TermuxPreferenceConstants javadoc changelog due to some old convention I keep on using. I didn't do it currently cause it would have broken multiple commits on my local repo.

@EduardDurech
Copy link
Contributor Author

Also ideally pull requests shouldn't be sent from the master branch, create separate branche for each pull, useful if multiple pull requests need to be sent and you won't have to force push master branch on your repo after merging and can just delete pull branch.

Okay, will keep in mind, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants