Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear LineWrap flag when clearing lines using blockSet. #2971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatanZ
Copy link

@MatanZ MatanZ commented Sep 3, 2022

This commit resets a row's mLineWrapped flag, if the last column is cleared with spaces.

Without this the flag remains from a previous line after clearing, for example on escape sequence \e[2J.

To see the bug:

  1. Open termux (with font large enough for some of the message lines to wrap).
  2. run clear ; ls /
  3. press ctrl+alt+= to increase font size.

Notice that the some of the ls lines are now not left aligned.

@agnostic-apollo
Copy link
Member

Can you provide before and after screenshots showing the issue?

@MatanZ
Copy link
Author

MatanZ commented Sep 3, 2022

Start, 1920x1080 screen, terminal size: 27x40.

Note that the 5th and 7th line are wrapped:
Screenshot_1662220318

Results of ls before increasing fonts:
Screenshot_1662220325

Current master: After increasing fonts, 5th and 7th lines spaces wrapped to 6th and 8th lines respectively.
Screenshot_1662220356

With this commit (after the same process): display as expected.
Screenshot_1662221156

@agnostic-apollo
Copy link
Member

Yeah, I can confirm that there is an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants