Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more features for termux-storage-get #497

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

knyipab
Copy link

@knyipab knyipab commented Mar 13, 2022

This goal of this request is to enrich termux-storage-get to what "Open ..." and "Open Folder ..." usually do in PC, while keeping backward compatibility.

See show_usage() of pull request on termux-api-package for more detailed usage.

@knyipab
Copy link
Author

knyipab commented Mar 13, 2022

The folder function highly resembles SAF one, but termux-storage-get focuses on the concept of "Open ...", or perhaps termux-storage-get should be better do this job.

Also, let's consider this use case: user can pick one or multiple file(s) calling termux-storage-get, get URI(s) from stdout, and then manipulate the file URI(s) with termux-saf-* functions.

Therefore, please consider to adopt the changes, perhaps partly. Or even integrating it SAF as something like termux-saf-open would also be great.

@tareksander
Copy link
Member

I haven't tried it out but the code looks good to me.

@cunlem
Copy link

cunlem commented Sep 11, 2022

Wow this looks super useful. So many missing features have been implemented. Any chance we get this thing merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants