Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional number reset #351

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

justinseibert
Copy link

@justinseibert justinseibert commented Jan 10, 2022

Issues

Changes

  • Adds a resetDelay option to the Number prompt. Updates documentation.
  • Flashes the input before resetting
  • By default, disables the automatic reset behavior. Like others, I think this is more intuitive, but I am open to maintaining the original behavior if this is considered a breaking change.
  • Fixes an issue where deleting/erasing number input would not sync the typed value. This made it impossible to actually delete input which is now potentially necessary.

Example of 1-second delay with flashing reset:

Screen.Recording.2022-01-10.at.3.29.28.PM.mov

@satouriko
Copy link

Hi everyone, is there any chance we could move further on this issue? Really get troubled :(

@mkilpatrick
Copy link

Ditto to the above. The issue has been open for over 2 years and this solves it. Can we get it merged?

@mkilpatrick
Copy link

Bump

1 similar comment
@mkilpatrick
Copy link

Bump

@sakibul-islam
Copy link

I am using an 8-digit number input, which resets in the middle of typing. Why isn't this PR merged yet?

@mkilpatrick
Copy link

Is this project no longer maintained? This PR has been open for over 2 years now and there's been no response from the maintainers about adding it or not despite the multiple asks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number entry digits overwritten after 1s delay number: value timer should have visual cue
6 participants