Update DPRINT to be disabled properly #8624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgkeller
approved these changes
May 20, 2024
tt-aho
approved these changes
May 20, 2024
tt-dma
force-pushed
the
dma/8575_dprint_disable
branch
from
444d495
to
b5c07eb
Compare
tt-dma
force-pushed
the
dma/8575_dprint_disable
branch
from
b5c07eb
to
6d2aa4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously was relying on compiler optimizing out the empty dprint object creation and stream operator calls, but it looks like that doesn't work. Just use an
if (0)here to accomplish this, which keeps the syntax exactly the same as stdout.Also fix a thread safety issue with the dprint server teardown.
Passing CI: https://github.com/tenstorrent/tt-metal/actions/runs/9134780012