Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#0: Cache program cmds, convert cb configs from write linear to write packed #8604

Merged
merged 1 commit into from
May 21, 2024
Merged

#0: Cache program cmds, convert cb configs from write linear to write packed #8604

merged 1 commit into from
May 21, 2024

Conversation

tt-aho
Copy link
Contributor

@tt-aho tt-aho commented May 17, 2024

TODO here is to get rid of the cb updates, or at least optimize them when we are hitting cache.
Will do this in a separate pr once it's completed.

@tt-aho tt-aho requested review from abhullar-tt and aliuTT May 17, 2024 14:28
@aliuTT
Copy link
Contributor

aliuTT commented May 17, 2024

Another TODO: write configs for cbs 0 to MAX_USED, as opposed to 0 to MAX_CBS

@abhullar-tt
Copy link
Contributor

I had to back out a change that changes the CB page size assertion from being a multiple of 4 to a multiple of 16 as it seems like a number of ops are setting cb page sizes < 16. This may be okay if they aren't actually using the sync mechanisms of cbs but I think we should have this assertion since cbs are expected to work on 16B words

ah yeah #4040 is still open

@tt-aho
#0: Cache program cmds, convert cb configs from write linear to write…
3eea9c5 
… packed

Invalidate cache for enqueue program when program recompile triggered
Only send up to max cb for enqueue_program
@tt-aho tt-aho merged commit b5d7699 into main May 21, 2024
5 checks passed
@tt-aho tt-aho deleted the aho/enqueue-program branch June 3, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhullar-tt abhullar-tt abhullar-tt approved these changes

@pgkeller pgkeller pgkeller approved these changes

@aliuTT aliuTT aliuTT approved these changes

@tarafdarTT tarafdarTT tarafdarTT approved these changes

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

@kmabeeTT kmabeeTT Awaiting requested review from kmabeeTT kmabeeTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tt-aho @aliuTT @abhullar-tt @pgkeller @tarafdarTT