adds example #6
adds example #6
Conversation
fix bug
|
This looks really great! My only two comments are that we might want a more descriptive title (e.g. Benchmarking the TensorLy PARAFAC fitting methods) and that the note in the beginning should be in a note-block. |
|
Unfortunately, it looks like we don't have a TensorLy release that includes the datasets yet, but as soon as that is released, we can merge! |
|
About the note, it might be a good idea to link an issue or discussion thread on TensorLy in the note. That way, if someone is curious, they have a place to go to check progress or join the discussion. |
|
@MarieRoald Waiting for the new release has been an issue on our side for the past few weeks as well, we should try to push for it :) |
|
I agree - let's have a release in the next week or so, we have a huge amount of new features. We can also push for more frequent minor releases when necessary. |
|
It would be great with a new release @JeanKossaifi! Sorry for not responding sooner, we've both been swamped with work, but we'll hopefully have time to look a bit at it this weekend or so :) |
This PR adds a benchmark example to viz as we agreed in #4. This example is informative about how to use a dataset from tensorly and how to compare different methods even if they are not in tensorly.