moving solvers related code to solvers/* directory, improving fista and nnls_hals #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of the part of #542 related to solvers.
What this PR solves:
What this PR does:
(I left the old proximal file with the modified nnls_hals and fista solvers to show the changes, we can remove it before merging.)
solvers/penalizations.py
with a utility function to process input ridge/sparsity regularization (transform 1d input to list of correct length, avoid no regularization on only some modes which makes the factorization ill-posed).Possible improvements:
Note: If this PR is merged, I will proceed with the nonnegative algorithms improvements in #542.