Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Tenable AD Syslog APIs #538

Merged
merged 2 commits into from
May 21, 2024

Conversation

dheerajrp
Copy link
Contributor

Description

Added support for Tenable AD syslog APIs.
Methods available -

  • Retrieve all syslog instances - list
  • Create syslog instance - create
  • Get syslog instance by id - details
  • Update syslog instance - update
  • Delete syslog instance - delete
  • Send a test syslog notification by id - send_syslog_notification_by_id
  • Send a test syslog notification - send_notification

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tests added to test the event endpoints and their schema.
  • Sphinx build for the doc

Test Configuration:

  • Python Version(s) Tested: 3.9.0
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Updated broken test

minor changes
@dheerajrp dheerajrp requested review from tomeara and a team February 1, 2022 09:52
Copy link
Collaborator

@aseemsavio aseemsavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dheerajrp, Thanks for the PR; the changes look good. Could you sync your branch with the master branch and ensure all the tests pass?

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 21, 2024 14:13
Copy link

sonarcloud bot commented May 21, 2024

@SteveMcGrath SteveMcGrath dismissed aseemsavio’s stale review May 21, 2024 18:59

no longer working on the library

@SteveMcGrath SteveMcGrath merged commit 8639fd4 into master May 21, 2024
16 checks passed
@SteveMcGrath SteveMcGrath deleted the feature/tenable.ad-syslog branch May 21, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants