Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TenableAD Email Notifier APIs #527

Merged
merged 2 commits into from
May 21, 2024

Conversation

tushar-balwani
Copy link
Contributor

Description

Added Tenable.AD Email Notifier APIs

  • Retrieve all email-notifier instances. (list)
  • Create email-notifier instance. (create)
  • Get email-notifier instance by id. (details)
  • Update email-notifier instance. (update)
  • Delete email-notifier instance. (delete)
  • Send a test email notification by id (send_test_email_by_id)
  • Send a test email notification (send_test_email)

updated docs to support email notifier api details

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added tests for email-notifier endpoints to test responses
  • Added schema tests for testing payload inputs and response dict validation

Test Configuration:

  • Python Version(s) Tested: 3.8.6
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Added feature - TenableAD Email Notifier APIs

minor changes

fixed required field in schema for test email

typo correction
Copy link
Collaborator

@aseemsavio aseemsavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pl. merge master into your branch.

tenable/ad/email_notifiers/api.py Show resolved Hide resolved
@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 21, 2024 19:50
@SteveMcGrath SteveMcGrath dismissed aseemsavio’s stale review May 21, 2024 19:55

no longer working on library

Copy link

sonarcloud bot commented May 21, 2024

@SteveMcGrath SteveMcGrath merged commit e706489 into master May 21, 2024
16 checks passed
@SteveMcGrath SteveMcGrath deleted the feature/tenable.ad-email_notifier branch May 21, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants