Allow any visibilityStore + secondaryVisibilityStore combination #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
requested changes
May 8, 2024
There was a problem hiding this comment.
This is more complicated than this. Due to how custom search attributes feature is implemented differently between ES and SQL databases, it's not that simple.
Dual visibility is documented here: https://docs.temporal.io/visibility#dual-visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Any pair of
visibilityStoreandsecondaryVisibilityStoreis now allowed.Why?
This change allows migration between Elasticsearch and SQL advanced visibility in both directions.
How did you test it?
Checked in staging env.
defaultManagerSelector is not aware of the underlying datastore of its
visibilityManagerandsecondaryVisibilityManager.Potential risks
Different visibility backends may have different restrictions on the number of SearchAttributes and allowed queries. Therefore, additional validation may be required in
CreateSearchAttributeandListWorkflowExecutions.Documentation
Current version of
How to migrate Visibility databasedoes not mention any restrictions on the primary and secondary visibility stores.https://docs.temporal.io/self-hosted-guide/visibility#migrating-visibility-database
Is hotfix candidate?
No