Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/stretched-images #510

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

nishilfaldu
Copy link
Contributor

@nishilfaldu nishilfaldu commented May 13, 2024

  • The only blog image that looks a bit bad Binidxaba's. In my opinion we can ignore that one as it does have a lot of content crammed into one image and just take a precaution in the future not to do so. Accommodating for that one image will lead us to playing with height of the image container which will interfere with height of the hero of the blog which will throw nearby hero images out of alignment and the postgres images from our design team don't have a lot of height in them to expand (so when you expand them with explicit height - they will look bad)!

https://linear.app/tembo/issue/CLOUD-49/image-stretched-on-blog-if-not-a-specific-dimensions

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-510.d2nhjf1y5jley2.amplifyapp.com

Copy link
Contributor

@DarrenBaldwin07 DarrenBaldwin07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to get resized images from design team (all 400x600 - we have fixed the old images but we found an issue with some of the new branded graphics having inconsistent sizing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants