This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent heroku deployments do not need Procfile anymore, they use
npm start
plus this Procfile is bugguy
But the
npm start
of tellform right now uses grunt whith some grunt plugins declared as dev-dependencies and a linter which fails, so I needed to touch these too.Note that this is not only heroku but any server which needs to do npm start in a production environment without forever or watch
Motivation and Context
fix #324
How Has This Been Tested?
deploy on heroku almost worked, there is still an issue, maybe someone can help me with the grunt config since I did not use grunt in a long time:
NODE_ENV=development node_modules/.bin/grunt build
worksNODE_ENV=production node_modules/.bin/grunt build
produces all the files, no error, no js error at runtime (client and server) but the page is blank. everything seems to load:Types of changes
Checklist: