Add Preview Support for GHE endpoints #239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have been using this against GHE for a few months now without issues. Possible to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a draft proposal for enabling support for Drafts (
shadow-cat-preview) and Checks for GitHub Enterprise endpoints, it's an attempt to resolve the issues outlined in #235It implements this through a change in the
http.Transportimplementation by extending it with required headers.application/vnd.github.antiope-preview+jsonapplication/vnd.github.shadow-cat-preview+jsonIt doesn't currently offer any easy method to add further additions for V3 or V4, but there should be an optional field perform, if desired, in that case through new options.
I would appreciate feedback on this behavior, before I make further development investments.