Store and validate TaskRun/Run UIDs in pipeline task embedded status

[vdemeester]

Changes

See GHSA-w2h3-vvvq-3m53

This will ensure that scenarios like described in the linked advisory
cannot occur - we'll read the TaskRun/Run UID when we initially
add it to the embedded status, and if we ever encounter a
TaskRun/Run with the same name but a different UID in the future,
we'll throw an error.

Signed-off-by: Vincent Demeester [email protected]

/cc @abayer @wlynch @tektoncd/core-maintainers

/kind bug
/area security

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix CVE-2023-37264: the controller now validates `TaskRun` and `CustomRun` UID to make sure we only accept `TaskRun`s and `Run`s that have the matching UID.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/reconciler/pipelinerun/pipelinerun.go	91.8%	91.8%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	96.7%	96.1%	-0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/reconciler/pipelinerun/pipelinerun.go	91.8%	91.8%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	96.7%	96.1%	-0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/reconciler/pipelinerun/pipelinerun.go	91.8%	91.8%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	96.7%	96.1%	-0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/reconciler/pipelinerun/pipelinerun.go	91.8%	91.8%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	96.7%	96.1%	-0.6

[piyush-garg]

lgtm

[afrittoli]

Thanks @vdemeester for looking into this.
If someone can create a TaskRun in the cluster, they are likely able to edit the PipelineRun status as well and inject the TaskRun there.

This helps but we will have to let the Tekton controller sign *Run resources everytime there is an update to ensure that there was no tampering. If I'm not mistaken, we have the Spiffe/Spire integration almost finished to provide that capabilities.

[vdemeester]

If I'm not mistaken, we have the Spiffe/Spire integration almost finished to provide that capabilities.

Yes, but it's not going to be enabled by default.

[tekton-robot]

@vdemeester: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.