Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove taskref/pipelineref deprecated bundle field #7789

Merged
merged 1 commit into from
May 27, 2024
Merged

Remove taskref/pipelineref deprecated bundle field #7789

merged 1 commit into from
May 27, 2024

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Mar 21, 2024 •
edited

Changes

This field has been deprecated for about a year and half. So this is
removing this field from v1beta1 (it's not present in v1 already).

Closes #7411

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

`taskRef.bundle` and `pipelineRef.bundle` are now removed from `v1beta1` API version, as they were deprecated for about a year and half. Using them will result in a error when creating an object.

action required: make sure you migrate from `taskRef.bundle` and `pipelineRef.bundle` to the bundle resolver (see https://tekton.dev/docs/pipelines/migrating-v1beta1-to-v1/#replacing-taskrefbundle-and-pipelinerefbundle-with-bundle-resolver-a-idreplacing-taskrefbundle-and-pipelinerefbundle-with-bundle-resolver-a)

@tekton-robot tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2024
@vdemeester vdemeester added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2024
@vdemeester
Copy link
Member Author

@afrittoli @chitrangpatel @JeromeJu

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 100.0% 73.9% -26.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 100.0% 73.9% -26.1

JeromeJu
JeromeJu reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@JeromeJu JeromeJu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vdemeester , this looks generally good and thanks for helping with the codebase hygiene - just one question do we want to tombstone the field? Having this on my mind because perviously there were several fields regarding PipelineResources brought back for tombstone after getting removed. 🤔

docs/pipelines.md Outdated
taskRef:
name: echo-task
bundle: docker.com/myrepo/mycatalog
taskRef:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: tabs look a bit off here?

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 21, 2024
@vdemeester
Copy link
Member Author

Thanks @vdemeester , this looks generally good and thanks for helping with the codebase hygiene - just one question do we want to tombstone the field? Having this on my mind because perviously there were several fields regarding PipelineResources brought back for tombstone after getting removed. 🤔

Ah good point, that might be a problem for results or chains, so we could "keep" it in code, but do nothing.
cc @tektoncd/results-maintainers @tektoncd/chains-maintainers

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 100.0% 73.9% -26.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 100.0% 73.9% -26.1

@lcarva
Copy link
Contributor

lcarva commented Mar 21, 2024

There's some context here: #6430

Thanks @vdemeester , this looks generally good and thanks for helping with the codebase hygiene - just one question do we want to tombstone the field? Having this on my mind because perviously there were several fields regarding PipelineResources brought back for tombstone after getting removed. 🤔

Ah good point, that might be a problem for results or chains, so we could "keep" it in code, but do nothing. cc @tektoncd/results-maintainers @tektoncd/chains-maintainers

+1 removing the field can be problematic which is what we saw with PipelineResources. @wlynch explains the intricacies here: #6430

I believe it comes down to, let's prevent resources from being created with this attribute on release X. Then, when release X is the oldest supported release, we can safely drop the attribute.

@vdemeester
Copy link
Member Author

vdemeester commented Mar 21, 2024 •
edited

I believe it comes down to, let's prevent resources from being created with this attribute on release X. Then, when release X is the oldest supported release, we can safely drop the attribute.

Yes, that definitely make sense. We could start disallowing the field in the next release (or the release that ships this PR) while keeping the field for "clients" like chains… I can update the PR that way indeed.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 100.0% 73.9% -26.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 100.0% 73.9% -26.1

@vdemeester
Copy link
Member Author

Updated with : 

  • Keeping the field in the go code
  • Disallowing it at creation time (so that updates of existing object with the bundle wouldn't fail), does that make sense ?

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 100.0% 76.0% -24.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 100.0% 76.0% -24.0

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2024
@JeromeJu
Copy link
Member

JeromeJu commented Apr 2, 2024 •
edited

Looks like we'd also need to get rid of the feature flag (also in the CI maybe 🤔 )

@vdemeester vdemeester force-pushed the 7411-remove-bundle branch 2 times, most recently from 3dde7ac to 05da748 Compare April 2, 2024 15:20
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.8% 95.5% 0.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.8% 95.5% 0.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.8% 95.5% 0.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.8% 95.5% 0.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.8% 95.5% 0.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 3, 2024
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.8% 95.5% 0.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.8% 95.5% 0.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.9% -0.0

@JeromeJu
Copy link
Member

Do we need a lgtm from another company? if not I can lgtm this

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2024
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.3% 94.9% 0.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.3% 94.9% 0.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@vdemeester
Remove taskref/pipelineref deprecated bundle field
0c72d59 
This field has been deprecated for about a year and half. So this is
"removing" this field from v1beta1 (it's not present in v1 already).

The field is kept in the go code to provide a backward compatibility
for client code (like chains, …) but it will be disallowed by the
webhook. It will also be completely ignore by the rest of the code.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.4% 95.0% 0.6
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 97.6% 100.0% 2.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.4% 95.0% 0.6
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/pipelineref_validation.go 97.6% 100.0% 2.4

chitrangpatel
chitrangpatel approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@chitrangpatel chitrangpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, JeromeJu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JeromeJu,chitrangpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 13af266 into tektoncd:main May 27, 2024
13 checks passed
@vdemeester vdemeester deleted the 7411-remove-bundle branch May 28, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chitrangpatel chitrangpatel chitrangpatel approved these changes

@JeromeJu JeromeJu JeromeJu approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@jerop jerop Awaiting requested review from jerop

Assignees

@chitrangpatel chitrangpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate the legacy OCI bundles implementation
5 participants
@vdemeester @tekton-robot @lcarva @JeromeJu @chitrangpatel