-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reason of PipelineRun status for PipelineRun having tasks timeout #7744
base: main
Are you sure you want to change the base?
Conversation
352db1a
to
4070c54
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
I think we would want a release note since this is essentially a user-facing bug fix for the condition.Reason
4070c54
to
09a5d7b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to fix the starttime in unit tests. That might fix some of the errors.
Hi @pratap0007 are you actively working on this or shall we update the test results and close this one? |
Hi @JeromeJu, I am looking to fix the test soon |
This patch fixes to set the reason of PipelineRun status to PipelineRunTimeout if the tasks of a PipelineRun timeout because of the timeout.tasks parameter Signed-off-by: Shiv Verma <[email protected]>
09a5d7b
to
b0f6040
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
@pratap0007: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This patch fixes to set the reason of PipelineRun
status to PipelineRunTimeout if the tasks of a PipelineRun
timeout because of the timeout.tasks parameter
Fixes: #7573
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes