Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if timeout.tasks is reached pipeline status.reason should be PipelineRunTimeout #7573

Open
flokain opened this issue Jan 17, 2024 · 4 comments · May be fixed by #7744
Open

if timeout.tasks is reached pipeline status.reason should be PipelineRunTimeout #7573

flokain opened this issue Jan 17, 2024 · 4 comments · May be fixed by #7744
Assignees
@pratap0007
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@flokain
Copy link

flokain commented Jan 17, 2024 •
edited

Expected Behavior

if the tasks of a pipelineRun time out because of the timeout.tasks parameter, the reason for the PipelinRun satus should be PipelineRunTimeout.

Actual Behavior

status reason is Failed.

Steps to Reproduce the Problem

  1. have pipeline that has a sleep for ever task
  2. configure a pipelinrun and set timeout.tasks = "1m"
  3. inspect pipelinerun status = false, reason=failed.

Additional Info

  • Kubernetes version:

    Output of kubectl version:

Client Version: v1.25.3
Kustomize Version: v4.5.7
Server Version: v1.25.16-eks-8cb36c9

  • Tekton Pipeline version:

    Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Client version: 0.31.2
Chains version: v0.16.0
Pipeline version: v0.47.5
Triggers version: v0.24.0
Dashboard version: v0.35.0
@flokain flokain added the kind/bug Categorizes issue or PR as related to a bug. label Jan 17, 2024
@vdemeester
Copy link
Member

I do think it make sense (if any Task fails due to Timeout, to mark the PipelineRun has failed due to Timeout).
cc @tektoncd/core-maintainers

@JeromeJu
Copy link
Member

JeromeJu commented Feb 6, 2024

I do think it make sense (if any Task fails due to Timeout, to mark the PipelineRun has failed due to Timeout). cc @tektoncd/core-maintainers

Yes, this would be similar to what TaskRun has for timeout behaviour.

And just double checking if there is gonna be any concern with the change cc @AlanGreene 🤔

@AlanGreene
Copy link
Member

No concerns from the Dashboard's perspective

@pratap0007
Copy link
Contributor

/assign

pratap0007 added a commit to pratap0007/pipeline that referenced this issue Mar 7, 2024
@pratap0007
Fix reason of PipelineRun status for PipelineRun having tasks timeout
60126f4 
This patch fixes to set the reason of PipelineRun
status to PipelineRunTimeout if the tasks of a PipelineRun
time out because of the timeout.tasks parameter

Fixes: tektoncd#7573

Signed-off-by: Shiv Verma <[email protected]>
pratap0007 added a commit to pratap0007/pipeline that referenced this issue Mar 7, 2024
@pratap0007
Fix reason of PipelineRun status for PipelineRun having tasks timeout
352db1a 
This patch fixes to set the reason of PipelineRun
status to PipelineRunTimeout if the tasks of a PipelineRun
timeout because of the timeout.tasks parameter

Fixes: tektoncd#7573

Signed-off-by: Shiv Verma <[email protected]>
@pratap0007 pratap0007 linked a pull request Mar 7, 2024 that will close this issue
Open
8 tasks
@codegold79 codegold79 mentioned this issue Mar 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pratap0007 pratap0007

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reason of PipelineRun status for PipelineRun having tasks timeout pratap0007/pipeline
5 participants
@vdemeester @AlanGreene @flokain @pratap0007 @JeromeJu